Support for asynchronous mongo methods #443
Conversation
There was a problem hiding this comment.
Generally approved. I only have requests for some documentation / comments.
@StorytellerCZ Once this is merged, I think we should do an RC before publishing the next version, wdyt?
| if (isInsertType(methodName) && typeof args[1] !== 'function') args.splice(1, 1) | ||
| } | ||
|
|
||
| if (async && !Meteor.isFibersDisabled) { |
There was a problem hiding this comment.
Sorry for late review here. @klablink could you please add one or two lines of comments and summarize what's happening here in this if block.
I also would like to know about the logic behind the if-clause, because Meteor.isAsyncDisabled might be gone at some day, right?
| } | ||
| } | ||
|
|
||
| function _methodMutationAsync (methodName) { |
There was a problem hiding this comment.
Could you please add a short method-summary using jsDoc notation?
|
Any progress on this? @klablink @jankapunkt currently, I cannot get this package to play nicely with Meteor 3.0 alpha 19... |
|
I'll taking a look at this @dallman2, no worries |
|
@harryadel FYSA, I found a dependency issue while trying to make all this work with meteor 3. It seems that SimplSchema has moved to ES6 style imports. While looking into it, I found that this workaround was the generally accepted solution for working with SimplSchema (for the time being): https://github.com/jankapunkt/simple-schema-3 In the README for that repo, they state that the imports have to be updated to ES6 style (although I suspect there is a typo). Either way, I think that for collection2 to use SimplSchema, this line needs to use ES6 import syntax... I could be wrong though:) This is the error that I am getting on startup currently on alpha 19. |
|
Yeah the situation with simple schema is really frustrating. I will look into this later today |
The fix that I had suggested seemed to work, but I've ben working on other dependency issues, so I cannot verify that the complete correctness of the fix... |
| expect(doc.serverAV).toBe(1); | ||
| }); | ||
| it('runs function once', async function () { | ||
| const id = await callMongoMethod(collection, 'insert', [{}]) |
There was a problem hiding this comment.
How can we ensure if it's backwards compatible if all the tests now use the async version? Shouldn't we keep the old sync test and also async ones?
This is a question really as I'm new to the async lands 😅
|
@klablink I'm trying to push changes but it appears you've disabled the maintainers the ability to edit the PR, can you revert it? |
The implementation includes support for Meteor versions: 2.2, 2.13.3 and 3.0-alpha.15. This involved a considerable change to the code due to the fact that the three versions have a different way of handling remote collections. As expressed in the forum, we still have behaviour to clarify in version 3 in order to declare the work completed.