Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add waitForUpdate interface action #2960

Merged
merged 4 commits into from
Dec 17, 2024
Merged

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Dec 16, 2024

Adds waitForUpdate as an interface action, which lets developers wait for the Snap content to be updated by the Snap. This is useful when waiting for the Snap to populate the UI with information gathered asynchronously.

Fixes #2958

@FrederikBolding FrederikBolding marked this pull request as ready for review December 16, 2024 14:54
@FrederikBolding FrederikBolding requested a review from a team as a code owner December 16, 2024 14:54
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.51%. Comparing base (ba6c908) to head (750199f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2960   +/-   ##
=======================================
  Coverage   94.50%   94.51%           
=======================================
  Files         488      488           
  Lines       10473    10486   +13     
  Branches     1608     1609    +1     
=======================================
+ Hits         9898     9911   +13     
  Misses        575      575           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrederikBolding FrederikBolding merged commit 967360c into main Dec 17, 2024
169 checks passed
@FrederikBolding FrederikBolding deleted the fb/add-wait-for-update branch December 17, 2024 09:50
PatrykLucka pushed a commit that referenced this pull request Jan 13, 2025
Adds `waitForUpdate` as an interface action, which lets developers wait
for the Snap content to be updated by the Snap. This is useful when
waiting for the Snap to populate the UI with information gathered
asynchronously.

Fixes #2958
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a pattern for awaiting re-renders in snaps-jest
2 participants