Add loading variant for Snaps UI Button #2930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2930 +/- ##
=======================================
Coverage 94.49% 94.49%
=======================================
Files 487 487
Lines 10442 10442
Branches 1600 1600
=======================================
Hits 9867 9867
Misses 575 575 ☔ View full report in Codecov by Sentry. |
7 tasks
david0xd
force-pushed
the
dd/add-loading-btn-state
branch
from
d6ecd72 to
46fcace
Compare
FrederikBolding
approved these changes
Dec 9, 2024
Update manifest shasum Add loading variant to old button
david0xd
force-pushed
the
dd/add-loading-btn-state
branch
from
390db87 to
ec4a744
Compare
david0xd
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
Dec 17, 2024
## **Description** This PR enables loading button variant for Snaps UI. [](https://codespaces.new/MetaMask/metamask-extension/pull/28997?quickstart=1) #### Notes - Targets Snaps release integration PR: #29275 ## **Related issues** Fixes: MetaMask/snaps#2694 ## **Related PR dependencies** Snaps monorepo: MetaMask/snaps#2930 ## **Manual testing steps** 1. Create some example Snap for testing and add Snap UI Button with `loading` variant. Example: ```TypeScript <Button variant="loading">Loading button</Button> ``` ## **Screenshots/Recordings** ### **Before** Loading button variant was not available before. ### **After** https://github.com/user-attachments/assets/5afea22c-1951-4475-a908-aa5b97eafb6b ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
FrederikBolding
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Dec 20, 2024
](https://codespaces.new/MetaMask/metamask-extension/pull/28997?quickstart=1){kind=link}
## **Description** This PR enables loading button variant for Snaps UI. [](https://codespaces.new/MetaMask/metamask-extension/pull/28997?quickstart=1) #### Notes - Targets Snaps release integration PR: #29275 ## **Related issues** Fixes: MetaMask/snaps#2694 ## **Related PR dependencies** Snaps monorepo: MetaMask/snaps#2930 ## **Manual testing steps** 1. Create some example Snap for testing and add Snap UI Button with `loading` variant. Example: ```TypeScript <Button variant="loading">Loading button</Button> ``` ## **Screenshots/Recordings** ### **Before** Loading button variant was not available before. ### **After** https://github.com/user-attachments/assets/5afea22c-1951-4475-a908-aa5b97eafb6b ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds loading variant for Snap UI button. This button shows loading icon with an infinite animation.
Related ticket: #2694
Related extension PR: MetaMask/metamask-extension#28997
Loading button in action:
Screen.Recording.2024-12-09.at.16.26.44.mov