Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onSettingsPage export #2911

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Add onSettingsPage export #2911

wants to merge 4 commits into from

Conversation

GuillaumeRx
Copy link
Contributor

This PR adds a new onSettingsPage export that is used to display custom UI.

Fixes: #2874

@GuillaumeRx GuillaumeRx requested a review from a team as a code owner November 27, 2024 13:13
@GuillaumeRx GuillaumeRx marked this pull request as draft November 27, 2024 13:13
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.49%. Comparing base (cbe55de) to head (63c8dbc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2911      +/-   ##
==========================================
+ Coverage   94.48%   94.49%   +0.01%     
==========================================
  Files         487      488       +1     
  Lines       10427    10447      +20     
  Branches     1598     1602       +4     
==========================================
+ Hits         9852     9872      +20     
  Misses        575      575              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider letting Snaps expose settings that show up alongside the MetaMask settings
1 participant