Add new snap_getCurrencyRate RPC method
#2763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeRx
force-pushed
the
gr/get-rate-method
branch
from
bbe871f
to
5951037
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2763 +/- ##
==========================================
+ Coverage 94.38% 94.40% +0.01%
==========================================
Files 478 480 +2
Lines 10213 10240 +27
Branches 1561 1563 +2
==========================================
+ Hits 9640 9667 +27
Misses 573 573 ☔ View full report in Codecov by Sentry. |
GuillaumeRx
changed the title
snap_getRate RPC methodsnap_getCurrencyRate RPC method
GuillaumeRx
force-pushed
the
gr/get-rate-method
branch
from
2e26f7f
to
fec51f9
Compare
Mrtenz
reviewed
Sep 27, 2024
Mrtenz
reviewed
Sep 27, 2024
Mrtenz
reviewed
Sep 27, 2024
GuillaumeRx
force-pushed
the
gr/get-rate-method
branch
from
5dabb15
to
6b284dd
Compare
Mrtenz
reviewed
Sep 27, 2024
Mrtenz
reviewed
Sep 27, 2024
Mrtenz
reviewed
Sep 27, 2024
Mrtenz
previously approved these changes
Sep 27, 2024
Mrtenz
approved these changes
Sep 27, 2024
GuillaumeRx
added a commit
that referenced
this pull request
Oct 16, 2024
This adds the types for the `snap_getCurrencyRate` method in `snaps-sdk`. It was forgotten in #2763
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new permitted RPC method called
snap_getCurrencyRate.It takes a cryptocurrency symbol under the
currencyparam. (We currently only supportbtc) and return a rate object if the rate is available.Fixes: #2762