Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: Move form submit files to value property #2504

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Jun 20, 2024

This removes the files property of the FormSubmitEvent in favour of the value property.

Breaking changes

  • The type of FormSubmitEvent's value now includes File.

@Mrtenz Mrtenz marked this pull request as ready for review June 20, 2024 09:57
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.36%. Comparing base (ea36386) to head (7dcb76a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2504   +/-   ##
=======================================
  Coverage   94.36%   94.36%           
=======================================
  Files         441      441           
  Lines        9068     9068           
  Branches     1396     1396           
=======================================
  Hits         8557     8557           
  Misses        511      511           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mrtenz Mrtenz requested a review from a team as a code owner June 20, 2024 09:57
@Mrtenz Mrtenz merged commit e01df64 into main Jun 20, 2024
156 checks passed
@Mrtenz Mrtenz deleted the mrtenz/remove-form-files branch June 20, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants