Add extend-runtime endowment #1624
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david0xd
force-pushed
the
dd/long-running-endowment
branch
from
0fa9fad
to
4d4d465
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1624 +/- ##
==========================================
+ Coverage 95.74% 95.80% +0.06%
==========================================
Files 239 241 +2
Lines 5410 5489 +79
Branches 837 853 +16
==========================================
+ Hits 5180 5259 +79
Misses 230 230
☔ View full report in Codecov by Sentry. |
david0xd
force-pushed
the
dd/long-running-endowment
branch
from
619a337
to
9d3a7e4
Compare
david0xd
force-pushed
the
dd/long-running-endowment
branch
from
3133d99
to
ee368d0
Compare
david0xd
force-pushed
the
dd/long-running-endowment
branch
2 times, most recently
from
d002508
to
ece95a7
Compare
david0xd
force-pushed
the
dd/long-running-endowment
branch
2 times, most recently
from
0e79062
to
951d6f1
Compare
Update coverage Add working proof of concept Update coverage and tests Refactor and fix tests Add test to the SnapController.test.ts and refactor Update coverage thresholds Add endowment:extend-runtime specification builder Update shasum of examples Code refactoring and improvements (1) Update coverage thresholds (increase) Rename endowment (longRunningJob => extendRuntime) Refactor the names of the timer events and similar Update examples shasum Minor endowment refactoring Add mechanism for resuming the timer of snaps that does not return in time Fix unit test Add some security mechanisms to prevent multiple calls Small refactoring Update shasums after rebase Update coverage thresholds Add new endowment to hardening tests Add mechanism to prevent endowment to be used multiple times per one request Update coverage thresholds Update after rebase Update tests and logic
david0xd
force-pushed
the
dd/long-running-endowment
branch
from
27d016b
to
3ec8449
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1604
PR for extension: MetaMask/metamask-extension#20543
This PR will add implementation for a new endowment that will allow snaps to run computation-heavy => time consuming tasks for a longer time.
The approach for dynamic extension of a snap runtime to a certain levels is accomplished by setting up a new way of communication channel through the notification system between Execution Environment and Snap Controller.