Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add size prop to buttons #2947

Closed
GuillaumeRx opened this issue Dec 11, 2024 · 0 comments · Fixed by MetaMask/metamask-extension#29275
Closed

Add size prop to buttons #2947

GuillaumeRx opened this issue Dec 11, 2024 · 0 comments · Fixed by MetaMask/metamask-extension#29275
Assignees
@FrederikBolding
Labels
release-12.11.0 Issue or pull request that will be included in release 12.11.0

Comments

@GuillaumeRx
Copy link
Contributor

Add a size prop to the button component to allow buttons to have a smaller font-size
@FrederikBolding FrederikBolding self-assigned this Dec 12, 2024
@FrederikBolding FrederikBolding mentioned this issue Dec 12, 2024
Merged
FrederikBolding added a commit that referenced this issue Dec 12, 2024
@FrederikBolding
feat: Add size prop to Button (#2953)
b0036f5 
Add `size` prop to buttons, letting devs size them similarly to `Text`. 

Progresses #2947
@FrederikBolding FrederikBolding mentioned this issue Dec 17, 2024
Merged
github-merge-queue bot pushed a commit to MetaMask/metamask-extension that referenced this issue Dec 20, 2024
@FrederikBolding @david0xd @GuillaumeRx
chore: Bump Snaps packages (#29275)
4e255c1 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Bump Snaps packages and handle any required changes.

Summary of Snaps changes:
- Allow async initialization logic for Snap bundles
- Add `onSettingsPage` export
- Add `Banner` component
- Support `size` prop on `Button`
- Support `fontWeight` prop on `Text`
- Add `loading` state for `Button`
- Use BigInt for processing insight chain IDs

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/29275?quickstart=1)

## **Related issues**
Closes MetaMask/snaps#2939
Closes MetaMask/snaps#2947
Closes MetaMask/snaps#2874
Closes MetaMask/snaps#2694

---------

Co-authored-by: David Drazic <[email protected]>
Co-authored-by: Guillaume Roux <[email protected]>
@metamaskbot metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FrederikBolding FrederikBolding

Labels
release-12.11.0 Issue or pull request that will be included in release 12.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Bump Snaps packages MetaMask/metamask-extension
3 participants
@FrederikBolding @GuillaumeRx @metamaskbot