-
Notifications
You must be signed in to change notification settings - Fork 565
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: Init WASM modules using Base64 (#2913)
This PR changes the WASM loader slightly to package the WASM source code using Base64 and decode it at runtime. This has multiple effects: - Fixes an obscure OOM bug in Firefox that would only occur on Mac OS (possibly due to extremely large arrays?) - Reduces bundle size for Snaps that leverage WASM - Prevents bundler slowdown due to large arrays needing to be parsed by Babel This adds minor overhead to initializing WASM bundles, but this seems worth it given the effects above.
- Loading branch information
1 parent
03cd5d6
commit 0fe7eda
Showing
3 changed files
with
27 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters