-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove testing site #7
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-g-j
changed the title
init: removed site package, updated yarn to 3.6.1, removed dapp workf…
feat: remove testing site
Mar 28, 2024
owencraston
previously approved these changes
Mar 29, 2024
owencraston
force-pushed
the
feat/remove-testing-site
branch
from
March 29, 2024 02:13
78c71da
to
b007b99
Compare
I ran through all test cases below after building the snap from this branch and all PASSED ✅ valid address: 0x83fbdFB42df1eA8cD02a9B28a8F62Cb219D48561You should see valid address message and then go through adding account flow valid ENS: vitalik.ethYou should see resolved Ethereum address message and then go through adding account flow valid address with ENS reverse lookup enabled: 0x225f137127d9067788314bc7fcc1f36746a3c3B5You should see resolved ENS name message and then go through adding account flow duplicate addressYou should see valid address message and then go through adding account flow and then receive error message: "Account address already in use" invalid address: 0x123You should see invalid address error message invalid ENS: abcdefg.ethYou should see invalid ENS error message invalid input: abcdYou should see invalid input error message smart contract address (UniswapV3 Sepolia: 0x0227628f3F023bb0B980b67D528571c95c6DaC1c)You should see smart contract addresses are not supported yet message |
gantunesr
reviewed
Mar 29, 2024
gantunesr
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
build-lint-test.yml
to build the snap before running the test since the tests require a built snap bundle to runReviewer check list