test: increase test coverage

[k-g-j]

Description

PR adds more unit tests for specific flows and error messages with the keyring.ts file. There is a minor refactor in the createAccount method to check for duplicate accounts.

• Fixes #254
• See: #244

Pre-requisites

• https://github.com/MetaMask/accounts-planning/issues/308
  • feat(272): add chainId to Keyring API requests (transaction/typed message) eth-snap-keyring#231
  • https://github.com/MetaMask/accounts-planning/issues/307

Test Coverage Report

Summary

The test coverage has been updated as part of the efforts to increase the code coverage for the snap-account-abstraction-keyring module. The tests were executed with yarn test:coverage --no-cache, ensuring that cached results did not influence the outcomes. The coverage for the keyring.ts file is now above 95%.

• Test Suites: 1 passed, 1 total
• Tests: 35 passed, 35 total

Coverage Overview

---------------------|---------|----------|---------|---------|-------------------------
File                 | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s       
---------------------|---------|----------|---------|---------|-------------------------
All files            |   87.58 |    60.63 |   82.45 |   87.75 |                         
 snap                |     100 |      100 |     100 |     100 |                         
  hardhat.config.ts  |     100 |      100 |     100 |     100 |                         
 snap/src            |   92.34 |    67.74 |    87.5 |   92.26 |                         
  keyring.ts         |   95.67 |    67.92 |     100 |   95.62 | 195,443-445,547-549,562 
  logger.ts          |      75 |    57.14 |   55.55 |      75 | 64,81-92,112-122        
  permissions.ts     |     100 |      100 |     100 |     100 |                         
  stateManagement.ts |    62.5 |      100 |      50 |    62.5 | 18-25                   
 snap/src/constants  |   93.75 |        0 |     100 |   93.75 |                         
  aa-factories.ts    |     100 |      100 |     100 |     100 |                         
  chain-ids.ts       |     100 |      100 |     100 |     100 |                         
  chainConfig.ts     |     100 |      100 |     100 |     100 |                         
  dummy-values.ts    |   88.88 |        0 |     100 |   88.88 | 15                      
  entrypoints.ts     |     100 |      100 |     100 |     100 |                         
 snap/src/utils      |      72 |    42.85 |   68.75 |    72.6 |                         
  ecdsa.ts           |     100 |      100 |     100 |     100 |                         
  util.ts            |   43.33 |        0 |      50 |   42.85 | 15-27,37-49,105         
  validation.ts      |   89.47 |       80 |     100 |   89.47 | 49,81-84,88             
---------------------|---------|----------|---------|---------|-------------------------

[socket-security]

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/[email protected]	Transitive: environment, eval, filesystem, network, shell, unsafe	+298	523 MB	simenb

View full report↗︎

[socket-security]

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

[k-g-j]

@SocketSecurity ignore npm/[email protected]

[ccharly]

LGTM! Thanks for all those changes 😄