Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3.0.0 #131

Merged
merged 1 commit into from
Apr 24, 2023
Merged

v3.0.0 #131

merged 1 commit into from
Apr 24, 2023

Conversation

legobeat
Copy link
Contributor

This represents v3.0.0

@legobeat legobeat requested a review from a team as a code owner April 24, 2023 13:59
Gudahtt
Gudahtt approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@legobeat legobeat merged commit 7126261 into MetaMask:main Apr 24, 2023
@Gudahtt
Copy link
Member

Gudahtt commented Apr 24, 2023

I was about to publish this, but noticed that there appears to be a dirty lockfile. Maybe we can revert and fix that first?

legobeat added a commit to legobeat/safe-event-emitter that referenced this pull request Apr 24, 2023
@legobeat
Revert "v3.0.0 (MetaMask#131)"
7de63b1 
This reverts commit 7126261.
legobeat added a commit to legobeat/safe-event-emitter that referenced this pull request Apr 24, 2023
@legobeat
v3.0.0 (MetaMask#131)
29b5b94
@legobeat legobeat mentioned this pull request Apr 24, 2023
Merged
@legobeat
Copy link
Contributor Author

legobeat commented Apr 24, 2023 •
edited
Loading

I was about to publish this, but noticed that there appears to be a dirty lockfile. Maybe we can revert and fix that first?

Ups, my bad. You mean like #132? Think we could temporarily enable rebase-merging for it as I guess it shouldn't be squashed?

@Gudahtt
Copy link
Member

Gudahtt commented Apr 24, 2023

I guess it doesn't especially matter since the releases are manual in this repo, but I'll enable rebase-merging anyway to make for a nicer commit history

Gudahtt pushed a commit that referenced this pull request Apr 24, 2023
@legobeat @Gudahtt
Revert "v3.0.0 (#131)"
503178b 
This reverts commit 7126261.
Gudahtt pushed a commit that referenced this pull request Apr 24, 2023
@legobeat @Gudahtt
v3.0.0 (#131)
ad99d38
@Gudahtt
Copy link
Member

Gudahtt commented Apr 24, 2023

A new version of the package @metamask/safe-event-emitter (3.0.0) was published at 2023-04-24T14:25:45.208Z from
[redacted]. The shasum of this package was 8c2b9073fe0722d48693143b0dc8448840daa3bd.

@legobeat legobeat deleted the v3.0.0 branch April 24, 2023 14:28
@legobeat
Copy link
Contributor Author

@Gudahtt ...Which registry was that published under? Only 2.0.0 present on npmjs.com as of now.

@Gudahtt
Copy link
Member

Gudahtt commented Apr 24, 2023 •
edited
Loading

.... strange. I have verified that it was published to npmjs.com (I even got that confirmation from them), but it's not showing up for me either

@Gudahtt
Copy link
Member

Gudahtt commented Apr 24, 2023

It's showing up now. It was just slow to update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@legobeat @Gudahtt