Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Touch up types #97

Merged
merged 8 commits into from
Aug 19, 2020
Merged

Touch up types #97

merged 8 commits into from
Aug 19, 2020

Conversation

rekmarks
Copy link
Member

@rekmarks rekmarks commented Aug 19, 2020

  • Add full docstrings to declarations file
    • The docstrings in the JavaScript source are not picked up by TypeScript, at least in VS Code.
    • Make minor edits to source docstrings in process.
  • Add typings for all send method signatures
  • Use RequestArguments interface for request method
  • Require opts.connectionStream param for initProvider
  • Update jsonrpc property on JsonRpcRequest and JsonRpcResponse interfaces
  • Update JsonRpcResponse interface to type with either result or error property
  • Lint types (per our config, but without adding dependencies)
    • Basically adds spacing and semicolons

@rekmarks rekmarks requested a review from a team as a code owner August 19, 2020 04:08
@rekmarks rekmarks requested a review from Gudahtt August 19, 2020 04:08

/**
* The network ID of the currently connected Ethereum chain.
* @deprecated Use {@link chainId} instead.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is daf.

@rekmarks rekmarks merged commit 6db8c33 into master Aug 19, 2020
@rekmarks rekmarks deleted the types-fixup branch August 19, 2020 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants