Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ts-bridge to 0.5.1 #363

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Bump ts-bridge to 0.5.1 #363

merged 3 commits into from
Sep 12, 2024

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Sep 11, 2024

This bumps ts-bridge to 0.5.0, which removes the need for @ts-bridge/shims and fixes some ESM issues.

@Mrtenz Mrtenz requested a review from a team as a code owner September 11, 2024 20:38
Copy link

socket-security bot commented Sep 11, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@ts-bridge/[email protected] None 0 314 kB mrten
npm/@ts-bridge/[email protected] filesystem, unsafe 0 130 kB mrten
npm/[email protected] None 0 146 kB guybedford

🚮 Removed packages: npm/@ts-bridge/[email protected], npm/@ts-bridge/[email protected], npm/@ts-bridge/[email protected], npm/[email protected]

View full report↗︎

GuillaumeRx
GuillaumeRx previously approved these changes Sep 12, 2024
@Mrtenz Mrtenz changed the title Bump ts-bridge to 0.5.0 Bump ts-bridge to 0.5.1 Sep 12, 2024
@Mrtenz Mrtenz merged commit 84452e1 into main Sep 12, 2024
18 checks passed
@Mrtenz Mrtenz deleted the mrtenz/ts-bridge-0.5.0 branch September 12, 2024 10:57
@legobeat
Copy link
Contributor

legobeat commented Oct 17, 2024

@Mrtenz It looks like this may have broken the build - between 17.1.2 and 18.0.0, there are now references to non-existent typedef file which breaks build when including this package.

https://github.com/MetaMask/snaps/actions/runs/11377787197/job/31652511752?pr=2817#step:5:9

node_modules/@metamask/providers/dist/initializeInpageProvider.d.cts:1:22 - error TS6053: File '/Users/runner/work/snaps/snaps/node_modules/@metamask/providers/src/readable-stream.d.ts' not found.

1 /// <reference path="../src/readable-stream.d.ts" />
                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~
node_modules/@metamask/providers/dist/MetaMaskInpageProvider.d.cts:1:22 - error TS6053: File '/Users/runner/work/snaps/snaps/node_modules/@metamask/providers/src/readable-stream.d.ts' not found.

1 /// <reference path="../src/readable-stream.d.ts" />
                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~
node_modules/@metamask/providers/dist/StreamProvider.d.cts:1:22 - error TS6053: File '/Users/runner/work/snaps/snaps/node_modules/@metamask/providers/src/readable-stream.d.ts' not found.

1 /// <reference path="../src/readable-stream.d.ts" />
                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants