Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /stream-provider export #351

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Add /stream-provider export #351

merged 1 commit into from
Jul 23, 2024

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Jul 23, 2024

This adds a new export for StreamProvider to the root of the package, i.e., @metamask/provider/stream-provider. Since #336 the stream provider is at ./dist/StreamProvider.cjs (and .mjs), but Browserify isn't able to resolve this. For compatibility with Browserify, I've added a stream-provider.js to the root, which will be used by Browserify and other tools that don't support package exports.

I haven't removed the previous ./dist/StreamProvider export for backwards compatibility, but we should consider it deprecated and remove it in the next major release.

@Mrtenz Mrtenz requested a review from a team as a code owner July 23, 2024 12:31
@Mrtenz Mrtenz merged commit e6ccaed into main Jul 23, 2024
18 checks passed
@Mrtenz Mrtenz deleted the mrtenz/stream-provider-export branch July 23, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants