Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Use named extension-port-stream import for Vite compatibility #331

Merged
merged 1 commit into from
Jun 19, 2024
Merged

refactor: Use named extension-port-stream import for Vite compatibility #331

merged 1 commit into from
Jun 19, 2024

Conversation

zouhangwithsweet
Copy link
Contributor

@zouhangwithsweet zouhangwithsweet requested a review from a team as a code owner June 16, 2024 02:55
@zouhangwithsweet
Copy link
Contributor Author

@zouhangwithsweet
Copy link
Contributor Author

Can you help me with a code review? @legobeat

@Mrtenz
Copy link
Member

Mrtenz commented Jun 18, 2024 •
edited
Loading

Rather than handling it here, what do you think about fixing this upstream, i.e., removing the default export from extension-port-stream?

cc @legobeat

@zouhangwithsweet
Copy link
Contributor Author

zouhangwithsweet commented Jun 18, 2024 •
edited
Loading

extension-port-stream?

Souds great. I just add the pr: MetaMask/extension-port-stream#57

@rekmarks

This comment was marked as resolved.

Sign in to view
@socket-security Socket Security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None 0 0 B

🚮 Removed packages: npm/[email protected]

View full report↗︎

rekmarks
rekmarks approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rekmarks rekmarks changed the title chore: unwrapping import for Vite compatibility. refactor: Use named extension-port-stream import for Vite compatibility Jun 19, 2024
@rekmarks rekmarks merged commit 878a6bb into MetaMask:main Jun 19, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rekmarks rekmarks rekmarks approved these changes

@davidmurdoch davidmurdoch Awaiting requested review from davidmurdoch

@Mrtenz Mrtenz Awaiting requested review from Mrtenz

@MajorLift MajorLift Awaiting requested review from MajorLift

@Gudahtt Gudahtt Awaiting requested review from Gudahtt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zouhangwithsweet @Mrtenz @rekmarks