Fix 8.1.1 changelog, add publishConfig to package.json #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanejonas
previously approved these changes
May 13, 2021
Gudahtt
reviewed
May 13, 2021
Co-authored-by: Mark Stacey <[email protected]>
shanejonas
approved these changes
May 13, 2021
rekmarks
commented
May 13, 2021
| "test": "jest", | ||
| "coverage": "jest --coverage", | ||
| "lint:eslint": "eslint . --cache --ext js,ts", | ||
| "lint:misc": "prettier '**/*.json' '**/*.md' '**/*.yml' --single-quote --ignore-path .gitignore", | ||
| "lint": "yarn lint:eslint && yarn lint:misc --check", | ||
| "lint:fix": "yarn lint:eslint --fix && yarn lint:misc --write", | ||
| "prepublishOnly": "yarn require-clean-git && yarn lint && yarn test", | ||
| "require-clean-git": "git diff --quiet || (echo 'Please clean the working directory.' && exit 1)" |
There was a problem hiding this comment.
For posterity: This is not a bad thing to do, but we don't do it anywhere else, and we probably aren't going to start.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should probably note in the changelog that the package is renamed 🤪
Since the package is scoped, we should also really have the appropriate
publishConfigin the manifest. Also fixes some package.json scripts.