fix: refactor to BaseProvider #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rekmarks
requested changes
Apr 23, 2021
There was a problem hiding this comment.
Great addition with the tests!
I haven't reviewed them yet, because there's a fair amount in BaseProvider that should be moved to MetaMaskInpageProvider. BaseProvider should only include the non-deprecated events, properties, and methods defined in EIP-1193.
shanejonas
commented
Apr 27, 2021
shanejonas
commented
Apr 27, 2021
rekmarks
requested changes
Apr 28, 2021
shanejonas
force-pushed
the
fix/refactor-base-provider
branch
from
c34952a to
dbac811
Compare
rekmarks
requested changes
Apr 28, 2021
rekmarks
reviewed
Apr 28, 2021
| @@ -0,0 +1,307 @@ | |||
| const { BaseProvider } = require('../dist'); | |||
There was a problem hiding this comment.
For posterity, the reason these tests worked with the BaseProvider streams set up incorrectly (see comment and changes here) is because these tests mock JsonRpcEngine.handle, and so we're not testing the stream piping underlying that method at all.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.