Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce web3 shim console noise #133

Merged
merged 1 commit into from
Jan 12, 2021
Merged

Reduce web3 shim console noise #133

merged 1 commit into from
Jan 12, 2021

Conversation

rekmarks
Copy link
Member

  • Only log the distinct web3 shim warnings once
  • Only send web3 shim usage notification to background once

@rekmarks rekmarks requested a review from Gudahtt January 12, 2021 19:31
@rekmarks rekmarks requested a review from a team as a code owner January 12, 2021 19:31
Gudahtt
Gudahtt approved these changes Jan 12, 2021
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rekmarks rekmarks merged commit cc54003 into main Jan 12, 2021
@rekmarks rekmarks deleted the reduce-web3-shim-noise branch January 12, 2021 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rekmarks @Gudahtt