adding edge-chromium support for createExternalExtensionProvider (#318)

* adding edge-chromium support for createExternalExtensionProvider * Update package.json version Co-authored-by: legobeat <[email protected]> * Update CHANGELOG.md Co-authored-by: legobeat <[email protected]> * Update CHANGELOG.md Change link to file to link to pr Co-authored-by: Elliot Winkler <[email protected]> * chore: update test coverage thresholds --------- Co-authored-by: legobeat <[email protected]> Co-authored-by: Elliot Winkler <[email protected]> Co-authored-by: legobt <[email protected]> Co-authored-by: Maarten Zuidhoorn <[email protected]>
MetaMask · Oct 3, 2024 · 8ccf228 · 8ccf228
1 parent 5175349
commit 8ccf228
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Fixed
+
+- Added support for edge-chromium to `createExternalExtensionProvider` ([#318](https://github.com/MetaMask/providers/pull/318))
+
 ## [17.2.0]
 
 ### Changed

diff --git a/jest.config.js b/jest.config.js
@@ -45,10 +45,10 @@ const baseConfig = {
   // An object that configures minimum threshold enforcement for coverage results
   coverageThreshold: {
     global: {
-      branches: 64.95,
+      branches: 64.65,
       functions: 65.65,
-      lines: 66.04,
-      statements: 66.13,
+      lines: 65.51,
+      statements: 65.61,
     },
   },
 

diff --git a/src/extension-provider/createExternalExtensionProvider.ts b/src/extension-provider/createExternalExtensionProvider.ts
@@ -53,7 +53,20 @@ export function createExternalExtensionProvider(
  * @returns The extension ID.
  */
 function getExtensionId(typeOrId: ExtensionType) {
-  const ids =
-    browser?.name === 'firefox' ? config.firefoxIds : config.chromeIds;
+  let ids: {
+    stable: string;
+    beta: string;
+    flask: string;
+  };
+  switch (browser?.name) {
+    case 'edge-chromium':
+      ids = config.edgeChromiumIds;
+      break;
+    case 'firefox':
+      ids = config.firefoxIds;
+      break;
+    default:
+      ids = config.chromeIds;
+  }
   return ids[typeOrId as keyof typeof ids] ?? typeOrId;
 }
diff --git a/src/extension-provider/external-extension-config.json b/src/extension-provider/external-extension-config.json
@@ -4,6 +4,11 @@
     "beta": "pbbkamfgmaedccnfkmjcofcecjhfgldn",
     "flask": "ljfoeinjpaedjfecbmggjgodbgkmjkjk"
   },
+  "edgeChromiumIds": {
+    "stable": "ejbalbakoplchlghecdalmeeeajnimhm",
+    "beta": "pbbkamfgmaedccnfkmjcofcecjhfgldn",
+    "flask": "ljfoeinjpaedjfecbmggjgodbgkmjkjk"
+  },
   "firefoxIds": {
     "stable": "[email protected]",
     "beta": "[email protected]",