Support for customizable logger for incoming/outgoing messages #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weizman
changed the title
mcmire
reviewed
May 30, 2023
src/BasePostMessageStream.ts
Outdated
| } | ||
|
|
||
| private _log(data: StreamData, out: boolean) { | ||
| this._logger.logger( |
There was a problem hiding this comment.
Similar comment as MetaMask/extension-port-stream#46 (comment).
mcmire
previously approved these changes
Jun 6, 2023
There was a problem hiding this comment.
It might be better to call public methods in tests instead of protected methods, but I see that that is already an established practice, so there's not much we can do about that. I also have a suggestion for how these tests could be written without the use of promises, but, it's understandable enough without it, so, your call.
weizman
commented
Jun 7, 2023
weizman
commented
Jun 7, 2023
FrederikBolding
approved these changes
Jun 15, 2023
| this._postMessage(data); | ||
| cb(); | ||
| } | ||
|
|
||
| _setLogger(log: Log) { |
There was a problem hiding this comment.
We should probably stop using _ prefixes, but out of scope for this PR.
This was referenced Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to add support for customizable logger for incoming/outgoing messages.
This will serve other users of this package as well as MetaMask specifically MetaMask/metamask-extension#19325