Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement JavaScript-based constraints #220

Merged
merged 10 commits into from
Mar 15, 2024
Merged

Implement JavaScript-based constraints #220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
fff63ba
Implement JavaScript-based constraints
Mrtenz Sep 30, 2023
27068f9
Add more constraints for README.md and pull_request_template.md
Mrtenz Sep 30, 2023
cb457d1
Update constraints to match latest module template
Mrtenz Mar 7, 2024
4eb1637
Use latest version of Yarn
Mrtenz Mar 7, 2024
ee1bd6f
Check if types export is the first
Mrtenz Mar 7, 2024
ec7ca82
Fix linting of Yarn config
Mrtenz Mar 7, 2024
57d3d3e
Revert change to ESLint config files
Mrtenz Mar 7, 2024
61a0f08
Update `files` constraint
Mrtenz Mar 8, 2024
4657151
Get workspace name from Yarn identifier instead of folder name
Mrtenz Mar 8, 2024
984dc40
Fix jsdoc
Mrtenz Mar 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .depcheckrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"@lavamoat/preinstall-always-fail",
"@metamask/auto-changelog",
"@types/*",
"@yarnpkg/types",
"prettier-plugin-packagejson",
"ts-node",
"typedoc"
Expand Down
14 changes: 14 additions & 0 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,20 @@ module.exports = {
extends: ['@metamask/eslint-config-nodejs'],
},

{
files: ['yarn.config.cjs'],
parserOptions: {
sourceType: 'script',
ecmaVersion: 2020,
mcmire marked this conversation as resolved.
Show resolved Hide resolved
},
settings: {
jsdoc: {
mode: 'typescript',
mcmire marked this conversation as resolved.
Show resolved Hide resolved
},
},
extends: ['@metamask/eslint-config-nodejs'],
},

{
files: ['*.test.ts', '*.test.js'],
extends: [
Expand Down
52 changes: 0 additions & 52 deletions .yarn/plugins/@yarnpkg/plugin-constraints.cjs
View file
Open in desktop

This file was deleted.

786 changes: 0 additions & 786 deletions .yarn/releases/yarn-3.2.1.cjs
View file
Open in desktop

This file was deleted.

893 changes: 893 additions & 0 deletions .yarn/releases/yarn-4.1.1.cjs
View file
Open in desktop

Large diffs are not rendered by default.

8 changes: 5 additions & 3 deletions .yarnrc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
compressionLevel: mixed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for these new config options?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They were added by Yarn when updating the version. I haven't changed anything.


enableGlobalCache: false

enableScripts: false

enableTelemetry: 0
Expand All @@ -11,7 +15,5 @@ nodeLinker: node-modules
plugins:
- path: .yarn/plugins/@yarnpkg/plugin-allow-scripts.cjs
spec: "https://raw.githubusercontent.com/LavaMoat/LavaMoat/main/packages/yarn-plugin-allow-scripts/bundles/@yarnpkg/plugin-allow-scripts.js"
- path: .yarn/plugins/@yarnpkg/plugin-constraints.cjs
spec: "@yarnpkg/plugin-constraints"

yarnPath: .yarn/releases/yarn-3.2.1.cjs
yarnPath: .yarn/releases/yarn-4.1.1.cjs
mcmire marked this conversation as resolved.
Show resolved Hide resolved
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,11 @@ Follow these instructions when using this template.

## Installation

`yarn add @metamask/this-module`
`yarn add @metamask/metamask-module-template`

or

`npm install @metamask/this-module`
`npm install @metamask/metamask-module-template`

## Usage

Expand Down
99 changes: 0 additions & 99 deletions constraints.pro
View file
Open in desktop

This file was deleted.

11 changes: 6 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "@metamask/module-template",
"name": "@metamask/metamask-module-template",
"version": "0.0.0",
"description": "The MetaMask Node module template",
"homepage": "https://github.com/MetaMask/metamask-module-template#readme",
Expand All @@ -13,9 +13,9 @@
"sideEffects": false,
"exports": {
".": {
"types": "./dist/types/index.d.ts",
"import": "./dist/index.mjs",
"require": "./dist/index.js",
"types": "./dist/types/index.d.ts"
"require": "./dist/index.js"
},
"./package.json": "./package.json"
},
Expand All @@ -33,7 +33,7 @@
"lint:changelog": "auto-changelog validate --prettier",
"lint:constraints": "yarn constraints",
"lint:dependencies": "depcheck && yarn dedupe",
"lint:eslint": "eslint . --cache --ext js,ts",
"lint:eslint": "eslint . --cache --ext js,cjs,ts",
"lint:fix": "yarn lint:eslint --fix && yarn lint:constraints --fix && yarn lint:misc --write && yarn lint:dependencies && yarn lint:changelog",
"lint:misc": "prettier '**/*.json' '**/*.md' '**/*.yml' '!.yarnrc.yml' --ignore-path .gitignore --no-error-on-unmatched-pattern",
"prepack": "./scripts/prepack.sh",
Expand All @@ -52,6 +52,7 @@
"@types/node": "^16",
"@typescript-eslint/eslint-plugin": "^5.43.0",
"@typescript-eslint/parser": "^5.43.0",
"@yarnpkg/types": "^4.0.0-rc.52",
"depcheck": "^1.4.3",
"eslint": "^8.44.0",
"eslint-config-prettier": "^8.8.0",
Expand All @@ -71,7 +72,7 @@
"typedoc": "^0.23.15",
"typescript": "~4.8.4"
},
"packageManager": "yarn@3.2.1",
"packageManager": "yarn@4.1.1",
"engines": {
"node": "^18.18 || >=20"
},
Expand Down
Loading