Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable react native flipper redux debugger plugin #6851

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

jpcloureiro
Copy link
Contributor

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

Allows flipper to grab redux actions, show action payload & store state diff

Screenshots/Recordings

Screen.Recording.2023-07-20.at.11.38.46.mov

Issue

Required by #spike vault corruption investigation

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Lets flipper to grab redux actions, show action payload & store state diff
@jpcloureiro jpcloureiro requested a review from a team as a code owner July 20, 2023 10:41
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
react-native-flipper 0.206.0 None +0 120 kB flipper-bot
redux-flipper 2.0.2 None +1 130 kB plwai

@socket-security
Copy link

socket-security bot commented Jul 20, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: [email protected]

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@tommasini tommasini added team-mobile-client Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking release-7.5.0 Issue or pull request that will be included in release 7.5.0 labels Jul 20, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

85.7% 85.7% Coverage
0.0% 0.0% Duplication

@jpcloureiro
Copy link
Contributor Author

@SocketSecurity ignore [email protected]

@jpcloureiro jpcloureiro merged commit 9dc6e95 into main Jul 20, 2023
@jpcloureiro jpcloureiro deleted the enable-redux-debugger branch July 20, 2023 11:44
@github-actions github-actions bot locked and limited conversation to collaborators Jul 20, 2023
@wachunei
Copy link
Member

Yay finally! 👏

@leotm leotm restored the enable-redux-debugger branch August 2, 2023 14:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.5.0 Issue or pull request that will be included in release 7.5.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants