RN Reanimated: fix deprecated/ removed File.exists method #5592
+14
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpcloureiro
added
No QA Needed
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
sethkfman
reviewed
Jan 25, 2023
sethkfman
approved these changes
Feb 1, 2023
sethkfman
removed
the
needs-dev-review
|
I see that react-native-reanimated released v3 RC-10 with this fix https://github.com/software-mansion/react-native-reanimated/releases/tag/3.0.0-rc.10 We are currently using Reanimated2, the latest stable version. Let's keep an eye on it & prepare to do a major version bump when it gets out of RC stage |
|
For anyone dropping in here who wish to stay on v2: Has the aforementioned fix included. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
react-native-reanimated 2.11.0 uses a deprecated ruby method that breaks the command
pod installat least on ruby 2.6 onwards[1]Problem also spotted on react-native repository[2] as well as react-native-reanimated[3]
Screenshots/Recordings
This patch replaces the deprecated method with the recommended one[1]
[1] https://rubyapi.org/2.6/o/file#method-c-exist-3F
[2] facebook/react-native#35853
[3] software-mansion/react-native-reanimated#3919