fix: remove unecessary calls to third party apis

MetaMask · May 27, 2024 · 32e4d97 · 32e4d97
1 parent 8ee5376
commit 32e4d97
Show file tree

Hide file tree

Showing 2 changed files with 15,273 additions and 128 deletions.
diff --git a/app/components/UI/CollectibleContracts/index.js b/app/components/UI/CollectibleContracts/index.js
@@ -197,43 +197,18 @@ const CollectibleContracts = ({
     const updatableCollectibles = collectibles.filter((single) =>
       shouldUpdateCollectibleMetadata(single),
     );
-    if (updatableCollectibles.length !== 0) {
+
+    if (updatableCollectibles.length !== 0 && !useNftDetection) {
       updateAllCollectibleMetadata(updatableCollectibles);
     }
   }, [
     collectibles,
     updateAllCollectibleMetadata,
     isIpfsGatewayEnabled,
     displayNftMedia,
+    useNftDetection,
   ]);
 
-  /*   const updateCollectibleMetadata = useCallback(
-    async (collectible) => {
-      const { NftController } = Engine.context;
-      const { address, tokenId } = collectible;
-
-      const isIgnored = isCollectibleIgnored(collectible);
-
-      if (!isIgnored) {
-        if (String(tokenId).includes('e+')) {
-          removeFavoriteCollectible(selectedAddress, chainId, collectible);
-        } else {
-          await NftController.addNft(address, String(tokenId));
-        }
-      }
-    },
-    [chainId, removeFavoriteCollectible, selectedAddress, isCollectibleIgnored],
-  );
-
-  useEffect(() => {
-    // TO DO: Move this fix to the controllers layer
-    collectibles.forEach((collectible) => {
-      if (shouldUpdateCollectibleMetadata(collectible)) {
-        updateCollectibleMetadata(collectible);
-      }
-    });
-  }, [collectibles, updateCollectibleMetadata]); */
-
   const goToAddCollectible = useCallback(() => {
     setIsAddNFTEnabled(false);
     navigation.push('AddAsset', { assetType: 'collectible' });