validate addresses in qr codes #9916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Builds ready [9ae0c2f]
Page Load Metrics (420 ± 68 ms)
|
Gudahtt
reviewed
Nov 19, 2020
ui/app/pages/send/send.component.js
Outdated
| updateSendTo(scannedAddress) | ||
| updateGas = true | ||
| // Clean up QR code data after handling | ||
| const toError = getToErrorObject(scannedAddress, false, network) |
There was a problem hiding this comment.
Wow, that is an.... interesting method name and signature 😬. It does the trick though at least!
There was a problem hiding this comment.
Though actually, it does give a pretty strange error on testnets 🤔
Not ETH network, set to lowercase seems inappropriate here
There was a problem hiding this comment.
It might be worth using isValidAddress and INVALID_RECIPIENT_ADDRESS_ERROR directly perhaps, instead of using that rather confusing helper function
There was a problem hiding this comment.
@Gudahtt -- I was following the pattern in the file and had it working before I realized how... wonky it was. 🤦♂️
brad-decker
force-pushed
the
fix-9889
branch
from
9ae0c2f to
7a6e82f
Compare
Gudahtt
reviewed
Nov 19, 2020
Builds ready [7a6e82f]
Page Load Metrics (404 ± 56 ms)
|
brad-decker
force-pushed
the
fix-9889
branch
from
7a6e82f to
ba51649
Compare
Builds ready [ba51649]
Page Load Metrics (428 ± 71 ms)
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9889
Explanation: We didn't do any validation of the to address, and this would incorrectly interpret ERC-20 token send encoded uris as being sent to the token address. This PR just checks the validity of the address.
Valid QR code (ethereum:xxxx)
Invalid QR code (ethereum:xxxx/transfer?address=xxxx&uint256=1) vis a vis eip-681
Manual testing steps: