Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes CoinSwitch from Deposit screen, references to CoinSwitch #9869

Merged
merged 3 commits into from
Nov 16, 2020
Merged

Removes CoinSwitch from Deposit screen, references to CoinSwitch #9869

merged 3 commits into from
Nov 16, 2020

Conversation

nchastain
Copy link
Contributor

This pull request:

  1. Removes all references to CoinSwitch, including messages, metrics events and its row on the "Deposit" view
  2. When on mainnet, places the "Buy from Wyre" option above the "Direct Deposit Ether" option on the "Deposit" view (just a reordering, no functional changes). Because the button in from the "Main" view now reads "Buy" rather than "Deposit," it is more likely that users will arrive at this screen interested in purchasing ether, rather than depositing it.

@nchastain
Removes all CoinSwitch references and functionality, bumps Wyre to to…
0bfbc50 
…p spot on Deposit screen unless user on test network
@nchastain
Update messages.json
f81c2e7 
removes reference to CoinSwitch
@nchastain nchastain requested a review from a team as a code owner November 13, 2020 16:09
@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2020 •
edited
Loading

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@nchastain
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@danjm danjm self-requested a review November 13, 2020 17:20
@danjm danjm self-assigned this Nov 13, 2020
Gudahtt
Gudahtt reviewed Nov 13, 2020
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! It looks OK at first glance. The only thing I noticed was the leftover logo.

@nchastain
Delete coinswitch_logo.png
2e376a6 
Deletes coinswitch_logo.png
danjm
danjm approved these changes Nov 15, 2020
View reviewed changes
Copy link
Contributor

@danjm danjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gudahtt Gudahtt merged commit 179dbcb into MetaMask:develop Nov 16, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Gudahtt Gudahtt Gudahtt left review comments

@danjm danjm danjm approved these changes

@NiranjanaBinoy NiranjanaBinoy Awaiting requested review from NiranjanaBinoy

Assignees

@danjm danjm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nchastain @Gudahtt @danjm