Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make editable action item a button, autofocus input contents #9855

Merged
merged 1 commit into from
Nov 13, 2020
Merged

Make editable action item a button, autofocus input contents #9855

merged 1 commit into from
Nov 13, 2020

Conversation

darkwing
Copy link
Contributor

Explanation:

This PR converts the edit icon to a button so that it's focusable and that the account name is focused when clicked.

AccountEditFOcus

@darkwing darkwing requested a review from a team as a code owner November 11, 2020 18:02
@darkwing darkwing requested a review from danjm November 11, 2020 18:02
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

danjm
danjm approved these changes Nov 13, 2020
View reviewed changes
Copy link
Contributor

@danjm danjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darkwing darkwing merged commit d78e6dc into MetaMask:develop Nov 13, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danjm danjm danjm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darkwing @danjm