-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show a 'send eth' button on home screen in full screen mode #9845
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
This was implemented to match designs, I believe the reasoning being that there is already a 'send' button in the eth asset header. @rachelcope thoughts? https://www.figma.com/file/b8U583mpXW1FsPWfGFNT8C/Wallet-home-(popup-%2B-fullscreen)?node-id=217%3A103 |
As a user, I feel somewhat trained to look at that right column to send. Without this send button, it feels like something is broken or missing. |
As @brad-decker said, I recall we left off the "Send Eth" since there's already the call to action in the header. That said, I'm good with this change. I think the consistency of having those CTAs on the right side of the asset list make sense! 🚢 |
Actually, after looking back at the designs, I think the intent was to show the "Send ETH", "Send DAI", etc. on the hover state. Not sure if we want to make that update or what you think of it. But it does keeps the UI clean with fewer CTAs but makes the action still possible from the home screen. I'm also good with the original change suggested in this PR, to keep it simple for now. |
1e3ef92
to
5f949d2
Compare
Wow, whoops! I totally didn't catch that. I think that should be handled in a separate PR then? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
G2G! Thanks, @darkwing for catching this!
Yes, that makes sense to me! |
Explanation:
Presently there's no "Send ETH" button because we aren't passing a token address for the first item.
Manual testing steps: