Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary lock page #9793

Merged
merged 1 commit into from
Nov 5, 2020
Merged

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Nov 4, 2020

This page appears to serve the sole purpose of locking the extension and redirecting back to the base route if the page is refreshed during the onboarding flow. This ineffectual before the vault has been initialized, and it's a barrier to resuming interrupted onboarding flows when done after initialization.

This page appears to serve the sole purpose of locking the extension
and redirecting back to the base route if the page is refreshed during
the onboarding flow. This ineffectual before the vault has been
initialized, and it's a barrier to resuming interrupted onboarding
flows when done after initialization.
@Gudahtt Gudahtt force-pushed the remove-unnecessary-lock-page branch from b7b5a02 to 6fddbf2 Compare November 4, 2020 22:37
@metamaskbot
Copy link
Collaborator

Builds ready [6fddbf2]
Page Load Metrics (453 ± 68 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint298742188
domContentLoaded24367545114268
load24567745314368
domInteractive24367445114268

@Gudahtt Gudahtt marked this pull request as ready for review November 4, 2020 23:20
@Gudahtt Gudahtt requested a review from a team as a code owner November 4, 2020 23:20
Copy link
Contributor

@darkwing darkwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@Gudahtt Gudahtt merged commit f5265c2 into develop Nov 5, 2020
@Gudahtt Gudahtt deleted the remove-unnecessary-lock-page branch November 5, 2020 16:34
@github-actions github-actions bot locked and limited conversation to collaborators Nov 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants