Check specified chain ID against endpoint return value

[rekmarks]

Adds additional validation to chainId values in the network form, by comparing the specified value against the value returned by the endpoint.

[whymarrh]

Seems legit

[Gudahtt]

LGTM!

[Gudahtt]

LGTM!

[metamaskbot]

Builds ready [7af85c5]

• builds: chrome, firefox, opera
• bundle viz: background, ui, inpage, contentscript, ui-libs, bg-libs, phishing-detect
• dep viz: background
• all artifacts

Page Load Metrics (493 ± 87 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	31	121	49	21	10
		domContentLoaded	309	972	491	182	87
		load	311	973	493	182	87
		domInteractive	309	971	491	182	87

[metamaskbot]

Builds ready [be40a26]

• builds: chrome, firefox, opera
• bundle viz: background, ui, inpage, contentscript, ui-libs, bg-libs, phishing-detect
• dep viz: background
• all artifacts

Page Load Metrics (431 ± 50 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	30	102	43	19	9
		domContentLoaded	324	614	429	103	49
		load	326	616	431	104	50
		domInteractive	324	614	429	103	50

[Gudahtt]

LGTM!

[metamaskbot]

Builds ready [e376823]

• builds: chrome, firefox, opera
• bundle viz: background, ui, inpage, contentscript, ui-libs, bg-libs, phishing-detect
• dep viz: background
• all artifacts

Page Load Metrics (448 ± 59 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	30	79	43	15	7
		domContentLoaded	315	670	447	124	59
		load	316	671	448	124	59
		domInteractive	315	670	446	124	59

[Gudahtt]

Nit: .then => async/await

Suggested change

	const jsonRpcResponse = await window.fetch(rpcUrl, {
	method: 'POST',
	body: JSON.stringify({
	id: Date.now().toString(),
	jsonrpc: '2.0',
	method: rpcMethod,
	params: rpcParams,
	}),
	headers: {
	'Content-Type': 'application/json',
	},
	cache: 'default',
	})
	.then((httpResponse) => httpResponse.json())
	const httpResponse = await window.fetch(rpcUrl, {
	method: 'POST',
	body: JSON.stringify({
	id: Date.now().toString(),
	jsonrpc: '2.0',
	method: rpcMethod,
	params: rpcParams,
	}),
	headers: {
	'Content-Type': 'application/json',
	},
	cache: 'default',
	})
	const jsonRpcResponse = await httpResponse.json()

[Gudahtt]

Nit: unknown|undefined seems redundant 🤔 since undefined is a valid unknown value

Suggested change

	* @returns {Promise<unknown|undefined>} Returns the result of the RPC method call,
	* @returns {Promise<unknown>} Returns the result of the RPC method call,

[Gudahtt]

LGTM! Couple of small suggestions remain, but nothing blocking.

[Gudahtt]

I decided to merge this as-is so that we can get another RC up without further delay