Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename Ethereum Main Network -> Etherum Mainnet #9411

Merged
merged 1 commit into from
Sep 15, 2020

Conversation

brad-decker
Copy link
Contributor

@brad-decker brad-decker commented Sep 15, 2020

Replaces the phrase 'Etherum Main Network' with 'Ethereum Mainnet'. I treated this as a proper name, and replaced it in all places it existed in all translations as well. This does result in NETWORK_NAME_MAP from enums.js but it doesn't seem widely used.

On Develop
This PR

@metamaskbot
Copy link
Collaborator

Builds ready [ceef2ab]
Page Load Metrics (502 ± 78 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint30113492613
domContentLoaded26080750116278
load26181050216278
domInteractive26080750016278

@brad-decker brad-decker marked this pull request as ready for review September 15, 2020 19:21
@brad-decker brad-decker requested a review from a team as a code owner September 15, 2020 19:21
@brad-decker brad-decker requested a review from danjm September 15, 2020 19:21
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brad-decker brad-decker merged commit c97493c into develop Sep 15, 2020
@brad-decker brad-decker deleted the rename-main-network-label branch September 15, 2020 19:34
@github-actions github-actions bot locked and limited conversation to collaborators Sep 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants