Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused connections route #9394

Merged
merged 1 commit into from
Sep 11, 2020
Merged

Remove unused connections route #9394

merged 1 commit into from
Sep 11, 2020

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Sep 10, 2020

This route was used for the "Connections" page in Settings, which was removed in #7004

@Gudahtt
Remove unused connections route
a868316 
This route was used for the "Connections" page in Settings, which was
removed in #7004
@Gudahtt Gudahtt mentioned this pull request Sep 10, 2020
Merged
@metamaskbot
Copy link
Collaborator

Builds ready [a868316]
Page Load Metrics (529 ± 67 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint289344199
domContentLoaded30272952713967
load30373252913967
domInteractive30272952713967

@Gudahtt Gudahtt marked this pull request as ready for review September 11, 2020 03:19
@Gudahtt Gudahtt requested a review from a team as a code owner September 11, 2020 03:19
@Gudahtt Gudahtt requested a review from danjm September 11, 2020 03:19
whymarrh
whymarrh approved these changes Sep 11, 2020
View reviewed changes
Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit feab367 into develop Sep 11, 2020
@Gudahtt Gudahtt deleted the remove-unused-connections-route branch September 11, 2020 12:32
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@whymarrh whymarrh whymarrh approved these changes

@danjm danjm Awaiting requested review from danjm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gudahtt @metamaskbot @whymarrh