Feature/hide seedphrase when restoring vault #9329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickycodes
changed the title
rekmarks
requested changes
Aug 31, 2020
ui/app/pages/keychains/index.scss
Outdated
Comment on lines
154
to
158
| } | ||
|
|
||
| .import-account__input { | ||
| width: 350px; | ||
| } | ||
| &__input-label__disabled { | ||
| opacity: 0.5; | ||
| } |
There was a problem hiding this comment.
While we're here, we should do this and change the corresponding classname in the file:
Suggested change
| } | |
| .import-account__input { | |
| width: 350px; | |
| } | |
| &__input-label__disabled { | |
| opacity: 0.5; | |
| } | |
| &--disabled { | |
| opacity: 0.5; | |
| } | |
| } |
There was a problem hiding this comment.
ISTM that this class isn't being used in either of the vault files 🤔
Builds ready [946fabf]
Page Load Metrics (422 ± 63 ms)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once upon a time I made a PR to hide the seed phrase (treat it as password) on seed phrase import here: #8730
this PR adds that same functionality to
restore-vaultwhich I missed the first time.I also moved the error feedback just under the
textareanow:instead of:
consistency++
opening as a Draft as I am sure this is likely to break some tests.tests are passing now.