Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove web3 e2e tests #9159

Merged
merged 1 commit into from
Aug 7, 2020
Merged

Remove web3 e2e tests #9159

merged 1 commit into from
Aug 7, 2020

Conversation

rekmarks
Copy link
Member

@rekmarks rekmarks commented Aug 7, 2020

Remove unused web3 e2e tests.

@rekmarks rekmarks requested a review from a team as a code owner August 7, 2020 18:57
@rekmarks rekmarks requested a review from brad-decker August 7, 2020 18:57
@brad-decker
Copy link
Contributor

image

Damn man.

brad-decker
brad-decker approved these changes Aug 7, 2020
View reviewed changes
Copy link
Contributor

@brad-decker brad-decker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, pending infrastructure pass ;P

@metamaskbot
Copy link
Collaborator

Builds ready [b039171]
Page Load Metrics (613 ± 47 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint28513752
domContentLoaded3547686119847
load3567706139847
domInteractive3547686119847

@rekmarks rekmarks merged commit 5527a6d into develop Aug 7, 2020
@rekmarks rekmarks deleted the remove-web3-test branch August 7, 2020 19:29
Gudahtt pushed a commit that referenced this pull request Aug 7, 2020
@rekmarks @Gudahtt
Remove web3 e2e tests (#9159)
c3bc7de
Gudahtt added a commit that referenced this pull request Aug 10, 2020
@Gudahtt
Merge remote-tracking branch 'origin/master' into sync-master
3d9b545 
* origin/master: (44 commits)
  Add category in eventOpts (#9164)
  Update changelog for v8.0.7 (#9161)
  Version v8.0.7
  Remove web3 e2e tests (#9159)
  Add web3 usage metrics, prepare for web3 removal (#9144)
  Use `pathname` instead of URL for `currentPath` metrics parameter (#9158)
  Remove `url` parameter from `metricsEvent` (#9157)
  Change MetaMetrics category for background events (#9155)
  remove .network-name height
  Use [email protected] (#9154)
  Update 'react-devtools' to ^4.8.0 (#9140)
  Fix connection removal bug (#9137)
  Add source map validator to CI (#9135)
  Update source map validator target files (#9133)
  Improve sourcemap validator console report (#9131)
  Add `validate-source-maps` npm script (#9134)
  Non-zero exit code upon failure to validate source maps (#9132)
  Update `brfs` from v1.6.1 to v2.0.2 (#9115)
  Factor out `getEnvironment` function in build script (#9114)
  Update `browserify` from v16.2.3 to v16.5.1 (#9113)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brad-decker brad-decker brad-decker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rekmarks @brad-decker @metamaskbot