Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-zero exit code upon failure to validate source maps #9132

Merged
merged 1 commit into from
Aug 4, 2020
Merged

Non-zero exit code upon failure to validate source maps #9132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions development/sourcemap-validator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,23 @@ const fsAsync = pify(fs)
// if not working it may error or print minified garbage
//

start().catch(console.error)
start().catch((error) => {
console.error(error)
process.exit(1)
})


async function start () {
const targetFiles = [`inpage.js`, `contentscript.js`, `ui.js`, `background.js`]
let valid = true

for (const buildName of targetFiles) {
await validateSourcemapForFile({ buildName })
const fileIsValid = await validateSourcemapForFile({ buildName })
valid = valid && fileIsValid
}

if (!valid) {
process.exit(1)
}
}

Expand Down Expand Up @@ -59,6 +69,7 @@ async function validateSourcemapForFile ({ buildName }) {

console.log(` sampling from ${consumer.sources.length} files`)
let sampleCount = 0
let valid = true

const buildLines = rawBuild.split('\n')
const targetString = 'new Error'
Expand All @@ -71,6 +82,7 @@ async function validateSourcemapForFile ({ buildName }) {
const result = consumer.originalPositionFor(position)
// warn if source content is missing
if (!result.source) {
valid = false
console.warn(`!! missing source for position: ${JSON.stringify(position)}`)
// const buildLine = buildLines[position.line - 1]
console.warn(` origin in build:`)
Expand All @@ -86,6 +98,7 @@ async function validateSourcemapForFile ({ buildName }) {
const portion = line.slice(result.column)
const isMaybeValid = portion.includes(targetString)
if (!isMaybeValid) {
valid = false
console.error('Sourcemap seems invalid:')
console.log(`\n========================== ${result.source} ====================================\n`)
console.log(line)
Expand All @@ -94,6 +107,7 @@ async function validateSourcemapForFile ({ buildName }) {
})
})
console.log(` checked ${sampleCount} samples`)
return valid
}

function indicesOf (substring, string) {
Expand Down