Don't updatePendingTxs outside of block updates #8445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whymarrh
force-pushed
the
pending-tx-checks
branch
from
e2cd009 to
10f2b75
Compare
Gudahtt
approved these changes
Apr 28, 2020
There was a problem hiding this comment.
Makes sense to me!
The combination of checking each block and forcing a block update upon unlock should ensure the pending transactions are updated in a timely manner. I'm having trouble thinking of a scenario where this would skip updating a pending transaction.
tmashuang
approved these changes
Apr 29, 2020
Gudahtt
pushed a commit
that referenced
this pull request
Apr 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #8377
This PR reverts 507397f (#5431)—the call to
updatePendingTxs, in_updateMemstorein particular, caused an update to the store, resulting in a loop (further detailed in #8377). This removes the update there and switches the call in#submitPasswordto a less-specific request for block updates. All updates to the pending transactions should happen in the transactions "subsystem", where we currently update pending transactions each block.