Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused states #8345

Merged
merged 1 commit into from
Apr 16, 2020
Merged

Remove unused states #8345

merged 1 commit into from
Apr 16, 2020

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Apr 16, 2020

These state files were snapshots of the Redux state used for integration tests that have since been removed. Only three of these states were still used - the three that correspond with the remaining
integration tests.

The default state used when the test environment is spun up was changed to be the first of these three (confirm sig requests) so that the old default state could safely be removed as well.

@Gudahtt
Remove unused states
7e1d40a 
These state files were snapshots of the Redux state used for
integration tests that have since been removed. Only three of these
states were still used - the three that correspond with the remaining
integration tests.

The default state used when the test environment is spun up was changed
to be the first of these three (`confirm sig requests`) so that the old
default state could safely be removed as well.
@Gudahtt Gudahtt mentioned this pull request Apr 16, 2020
Merged
whymarrh
whymarrh approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit!

@metamaskbot
Copy link
Collaborator

Builds ready [7e1d40a]
Page Load Metrics (647 ± 47 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeNotificationfirstPaint3510446189
domContentLoaded3607606459847
load3627626479847
domInteractive3607606459847

@Gudahtt Gudahtt merged commit c2e95d8 into develop Apr 16, 2020
@Gudahtt Gudahtt deleted the remove-unused-states branch April 16, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennypollack jennypollack jennypollack approved these changes

@whymarrh whymarrh whymarrh approved these changes

@rekmarks rekmarks Awaiting requested review from rekmarks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gudahtt @metamaskbot @whymarrh @jennypollack