Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename non-existent selectedAccount prop to fromAccount #8337

Merged
merged 1 commit into from
Apr 15, 2020
Merged

Rename non-existent selectedAccount prop to fromAccount #8337

merged 1 commit into from
Apr 15, 2020

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Apr 14, 2020

The prop passed into the SignatureRequestHeader was changed from selectedAccount to fromAccount in #8079, but the header component itself was never updated to use the new prop name.

@Gudahtt
Rename non-existent selectedAccount prop to fromAccount
0c13bdd 
The prop passed into the SignatureRequestHeader was changed from
`selectedAccount` to `fromAccount` in #8079, but the header component
itself was never updated to use the new prop name.
@Gudahtt Gudahtt requested a review from rekmarks April 14, 2020 20:57
@metamaskbot
Copy link
Collaborator

Builds ready [0c13bdd]
Page Load Metrics (660 ± 14 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeNotificationfirstPaint358342105
domContentLoaded6087356593014
load6097376603014
domInteractive6087356593014

@Gudahtt Gudahtt mentioned this pull request Apr 14, 2020
Merged
whymarrh
whymarrh approved these changes Apr 15, 2020
View reviewed changes
Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit 8e03a96 into develop Apr 15, 2020
@Gudahtt Gudahtt deleted the rename-from-account-prop branch April 15, 2020 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rekmarks rekmarks rekmarks approved these changes

@whymarrh whymarrh whymarrh approved these changes

@danjm danjm Awaiting requested review from danjm

@jennypollack jennypollack Awaiting requested review from jennypollack

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gudahtt @metamaskbot @whymarrh @rekmarks