Refactor Menubar and AccountDetailsDropdown styles #8278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whymarrh
force-pushed
the
menu-bar-grid
branch
2 times, most recently
from
a01ccb2 to
723ecc6
Compare
|
And this works as well with account names that truncate. Edit: updated screenshots, after be17601
Screenshot of the full-screen, small viewport without the status indicator
|
danjm
reviewed
Apr 2, 2020
whymarrh
added a commit
to whymarrh/metamask-extension
that referenced
this pull request
Apr 2, 2020
This change removes the now-unused (as of MetaMask#8278) 3dots.svg icon.
whymarrh
added a commit
that referenced
this pull request
Apr 2, 2020
This change removes the now-unused (as of #8278) 3dots.svg icon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #8270 and #8274
This PR refactors the
MenubarandAccountDetailsDropdowncomponents and their styles with the goal of getting the positioning to be more good. This change drops the absolute positioning and replaces it with a grid that is always positioned correctly. Note that the padding was previously inconsistent, the connected status indicator was 22px from the left and the icon was 16px from the right.While I was at it:
Screenshots
Screenshot of the grid
Screenshot without indicator
For demonstration purposes, this is the popup without the indicator, also what you'd see in full-screen on a small viewport. (I took the screenshot of the popup with it removed in devtools because it was easier.) As of #8275 we don't render it at all, leaving just two children in the
.menu-barcontainer.