Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning to watchAsset API when editing a known token #8049

Merged
merged 3 commits into from
Feb 14, 2020
Merged

Add warning to watchAsset API when editing a known token #8049

merged 3 commits into from
Feb 14, 2020

Conversation

danfinlay
Copy link
Contributor

Screen Shot 2020-02-13 at 11 30 46 AM

@danfinlay danfinlay requested a review from whymarrh February 13, 2020 19:35
@danfinlay
Copy link
Contributor Author

Whoops, need to figure out the correct base for a hotfix on master.

@danfinlay danfinlay closed this Feb 13, 2020
@danfinlay
Copy link
Contributor Author

Added warning when reusing a symbol, also:

Screen Shot 2020-02-13 at 1 28 38 PM

@danfinlay danfinlay reopened this Feb 13, 2020
@danfinlay
Copy link
Contributor Author

We should cherry pick these commits into a new version, probably for publishing early next week.

@metamaskbot
Copy link
Collaborator

Builds ready [c2dafc9]
Page Load Metrics (751 ± 34 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeNotificationfirstPaint359152147
domContentLoaded5898967497134
load5918977517134
domInteractive5898957497134

@danfinlay danfinlay merged commit eb57763 into develop Feb 14, 2020
@danfinlay danfinlay deleted the watchAssetWarning branch February 14, 2020 20:32
Gudahtt pushed a commit that referenced this pull request Feb 14, 2020
@danfinlay @Gudahtt
Add warning to watchAsset API when editing a known token (#8049)
bca4594 
* Add warning when editing a known token with watchAsset API

* Add warning when watchAsset attempts to reuse token symbol
yqrashawn pushed a commit to yqrashawn/conflux-portal that referenced this pull request Feb 17, 2020
@danfinlay @yqrashawn
Add warning to watchAsset API when editing a known token (MetaMask#8049)
c630659 
* Add warning when editing a known token with watchAsset API

* Add warning when watchAsset attempts to reuse token symbol

* Linted
@srirambv srirambv mentioned this pull request Mar 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt left review comments

@whymarrh whymarrh Awaiting requested review from whymarrh

@danjm danjm Awaiting requested review from danjm

@jennypollack jennypollack Awaiting requested review from jennypollack

@rekmarks rekmarks Awaiting requested review from rekmarks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danfinlay @metamaskbot @Gudahtt