Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't overwrite state when setting inactive timeout #7579

Merged
merged 1 commit into from
Nov 26, 2019
Merged

Don't overwrite state when setting inactive timeout #7579

merged 1 commit into from
Nov 26, 2019

Conversation

whymarrh
Copy link
Contributor

@whymarrh whymarrh commented Nov 26, 2019 •
edited by rickycodes
Loading

Closes #7577

Using #putState here was clearing the other fields in the store and causing the Dai migration notification to reappear.

@whymarrh
Don't overwrite state when setting inactive timeout
c044400 
Using `#putState` here was clearing the other fields in the store.
rickycodes
rickycodes approved these changes Nov 26, 2019
View reviewed changes
Copy link
Contributor

@rickycodes rickycodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tmashuang tmashuang merged commit 5e34eef into MetaMask:develop Nov 26, 2019
@whymarrh whymarrh deleted the fix-dai-notification branch November 26, 2019 22:19
@bbondy bbondy mentioned this pull request Dec 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmashuang tmashuang tmashuang approved these changes

@Gudahtt Gudahtt Gudahtt approved these changes

@rickycodes rickycodes rickycodes approved these changes

@danjm danjm Awaiting requested review from danjm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@whymarrh @rickycodes @Gudahtt @tmashuang