Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metricsEvent to contextTypes #7439

Merged
merged 1 commit into from
Nov 15, 2019
Merged

Add metricsEvent to contextTypes #7439

merged 1 commit into from
Nov 15, 2019

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Nov 15, 2019

The metricsEvent context type was missing, resulting in an error when it was called.

@Gudahtt
Add metricsEvent to contextTypes
2818587 
The metricsEvent context type was missing, resulting in an error when
it was called.
@Gudahtt Gudahtt requested a review from rickycodes November 15, 2019 17:26
whymarrh
whymarrh approved these changes Nov 15, 2019
View reviewed changes
Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@metamaskbot
Copy link
Collaborator

Builds ready [2818587]

@Gudahtt Gudahtt merged commit 23ab6e2 into develop Nov 15, 2019
@whymarrh whymarrh deleted the fix-metrics-event-error branch November 15, 2019 18:04
@bbondy bbondy mentioned this pull request Dec 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whymarrh whymarrh whymarrh approved these changes

@rickycodes rickycodes rickycodes approved these changes

@danjm danjm Awaiting requested review from danjm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gudahtt @metamaskbot @rickycodes @whymarrh