Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn off full screen vs popup a/b test #7298

Merged
merged 1 commit into from
Oct 21, 2019
Merged

Turn off full screen vs popup a/b test #7298

merged 1 commit into from
Oct 21, 2019

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Oct 21, 2019

Turns off the full screen vs popup a/b test until we can implement a sound solution to redirecting the user to the dapp from full screen mode.

@danjm danjm force-pushed the turn-off-fullscreen-ab-test branch from 4ff9abc to cda9e3f Compare October 21, 2019 23:03
Gudahtt
Gudahtt approved these changes Oct 21, 2019
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@metamaskbot
Copy link
Collaborator

Builds ready [cda9e3f]

@Gudahtt Gudahtt merged commit 55bc993 into develop Oct 21, 2019
@whymarrh whymarrh deleted the turn-off-fullscreen-ab-test branch October 22, 2019 13:43
@bbondy bbondy mentioned this pull request Dec 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@whymarrh whymarrh Awaiting requested review from whymarrh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danjm @metamaskbot @Gudahtt