Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lessen the length of ENS validation to 3 #7285

Merged
merged 1 commit into from
Oct 17, 2019
Merged

Lessen the length of ENS validation to 3 #7285

merged 1 commit into from
Oct 17, 2019

Conversation

tmashuang
Copy link
Contributor

No description provided.

Gudahtt
Gudahtt approved these changes Oct 17, 2019
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! This seems to fix the issue.

@Gudahtt Gudahtt merged commit a646bfb into develop Oct 17, 2019
@tmashuang tmashuang deleted the ens-shortnames branch October 17, 2019 16:03
@Gudahtt Gudahtt mentioned this pull request Oct 17, 2019
Closed
@metamaskbot
Copy link
Collaborator

Builds ready [0fb3c2e]

@Gudahtt Gudahtt mentioned this pull request Oct 17, 2019
Merged
@bbondy bbondy mentioned this pull request Dec 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@danjm danjm Awaiting requested review from danjm

@whymarrh whymarrh Awaiting requested review from whymarrh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tmashuang @metamaskbot @Gudahtt