Fix tx history list grid layout #7272
Conversation
Builds ready [b742a20]
|
danjm
force-pushed
the
fix-tx-history-padding
branch
2 times, most recently
from
60b04c6 to
d471578
Compare
|
@Gudahtt I made some changes in response to your comments |
Builds ready [d471578]
|
Builds ready [d471578]
|
danjm
force-pushed
the
fix-tx-history-padding
branch
from
d471578 to
3ff9a5e
Compare
| "nonce nonce nonce" | ||
| "identicon action primary-amount" | ||
| "identicon status secondary-amount"; | ||
| grid-template-columns: 45px 145px 3fr; |
There was a problem hiding this comment.
I noticed that you're still omitting the fourth column here. Is there any reason for that? I'm not even sure what behavior to expect in this case, e.g. whether it defaults to 1fr or something else. Certainly if you don't specify something for the fourth column, using 3fr seems rather pointless ("3 parts" of the remaining space, when those are the only parts)
Setting the second column as 145px seems reasonable though - I can see why you did that. I do wonder whether that's long enough to fit any of the messages that might appear there though 🤔. I'm not sure where to find a full list of those, particularly the translated versions.
There was a problem hiding this comment.
oh right, the fourth column...
There was a problem hiding this comment.
Yeah, it defaults to 1fr Just pushed a commit which makes that explicit
Fitting long messages is an existing problem on that screen, with or without that change. Which should be addressed through design, but probably not in this issue?
There was a problem hiding this comment.
Sure, of course. I was more concerned about the possibility that this change made it worse (i.e. truncated a message that previous was not truncated). I don't think we need to worry about solving the general problem in this PR.
There was a problem hiding this comment.
Unfortunately there is still a regression here:
Current develop branch:
This branch:
The only status long enough to exceed the 145px is "Contract Deployment"; it looks like it needs at least 153px to fit without being truncated.
Though more importantly, this has brought my attention to a more substantial change; that it was three columns before, and is now four. The status was placed below the transaction category, not alongside it.
I would suggest restoring the third column, and leaving the status below the transaction category. Then there would be ample room to accommodate not only "Contract Deployment", but any translated category names that might be substantially longer.
Builds ready [3ff9a5e]
|
Builds ready [2703c73]
|
|
Closing in favour of #7319 |
Fixes #7036