Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci - install deps - limit install scripts to whitelist #7208

Merged
merged 9 commits into from
Sep 25, 2019
Merged

ci - install deps - limit install scripts to whitelist #7208

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
bc45ed0
ci - install deps - limit install scripts to those needed for build
kumavis Sep 23, 2019
8c8d145
Update .circleci/scripts/deps-install.sh
kumavis Sep 23, 2019
c235b83
ci - install deps - expand install scripts needed for tests
kumavis Sep 23, 2019
3428381
ci - install deps - expand install scripts needed for integration tests
kumavis Sep 23, 2019
b5278c9
ci - install deps - fix node-sass script ref
kumavis Sep 23, 2019
affebaf
github - set codeowners for scripts/deps-install
kumavis Sep 23, 2019
8e7dbca
development - add utility to show deps with install scripts
kumavis Sep 23, 2019
ddb1a25
lint fix
kumavis Sep 23, 2019
c9c69be
deps - move read-installed to devDeps
kumavis Sep 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ jobs:
- run:
name: Install deps
command: |
yarn --frozen-lockfile --har
.circleci/scripts/deps-install.sh
- run:
name: Collect yarn install HAR logs
command: |
Expand Down
12 changes: 12 additions & 0 deletions .circleci/scripts/deps-install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
#!/usr/bin/env bash
set -x

yarn --frozen-lockfile --har
kumavis marked this conversation as resolved.
Show resolved Hide resolved

# run each in subshell so directory change does not persist

# for build
(cd node_modules/node-sass && yarn run build)
(cd node_modules/optipng-bin && yarn run postinstall)
(cd node_modules/gifsicle && yarn run postinstall)
(cd node_modules/jpegtran-bin && yarn run postinstall)