Fix BigNumber conversion error #7088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case where the block gas limit in the MetaMask state is blank, an exception is sometimes thrown when that blank value is passed to `multiplyCurrencies` to be parsed as a hex number. Instead the minimum gas limit is now used instead whenever the block gas limit is falsy. This was already being done in one case anyway.
danjm
approved these changes
Aug 31, 2019
|
There are a lot of reported BigNumber errors on Sentry. I didn't see this among them, but I was only looking at the errors introduced with v7.1.0 - this problem is older than that. So it is possible it's affecting users. It was a bit challenging to search for in Sentry, because this "type" of error can be thrown from a such a wide variety of situations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case where the block gas limit in the MetaMask state is blank, an exception is sometimes thrown when that blank value is passed to
multiplyCurrenciesto be parsed as a hex number.Instead the minimum gas limit is now used instead whenever the block gas limit is falsy. This was already being done in one case anyway.