-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connections settings tab #7013
Connections settings tab #7013
Conversation
29a6143
to
dd29ae6
Compare
First question I have is whether we are certain we want to persist all connect request approvals? This will be a change in user experience. Might there be some users who like the default of these not being persisted? |
|
Good point. While I'm sure most users would prefer them be persisted, there are sure to be those that prefer nothing to be saved between sessions. The ideal solution might be a toggle, perhaps? One that defaults to persisting connections. I'm not sure how important that'd be to include in this release though. 🤔 |
I don't think that's quite ideal. I think we can comfortably pick one way and stick with it. |
dd29ae6
to
5bbda44
Compare
I guess the remove all button is there for users who really care |
I was thinking of it like an "Incognito mode". Certainly nothing we need right now though, granted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I noticed a few stray props that should be removed, but everything's good aside from that.
5bbda44
to
a6b254f
Compare
Refs #4703, #6904, #6955
This PR does a few things:
Some context:
Screenshots
Some finer details: