Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missed phrases to RU locale (got from en locale) #7012

Merged
merged 4 commits into from
Sep 4, 2019

Conversation

zlocate
Copy link
Contributor

@zlocate zlocate commented Aug 14, 2019

Added missed phrases from EN locale.

Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @zlocate, thanks a bunch of helping with translations! The JSON file currently has a few errors in its formatting—a tool/site like https://jsonlint.com can help if you want to have a go at fixing those up first.

(cc @MetaMask/translators any of y'all able to review this? 😅)

@zlocate
Copy link
Contributor Author

zlocate commented Aug 15, 2019

@whymarrh thank you for feedback. Some phrases adopted at Russian common grammar rules but i would like external review from native speakers (i'm native Russian speaker).
Sorry for breaking indent in source file. I will fix it asap

@zlocate
Copy link
Contributor Author

zlocate commented Aug 15, 2019

@whymarrh fixed. Please review current version.

@nujabes403
Copy link
Contributor

@zlocate Thank you for your effort!

whymarrh
whymarrh previously approved these changes Aug 21, 2019
Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @zlocate! ❤️

Copy link
Contributor

@dryajov dryajov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments/suggestions.

Thanks for contributing.

app/_locales/ru/messages.json Outdated Show resolved Hide resolved
app/_locales/ru/messages.json Outdated Show resolved Hide resolved
app/_locales/ru/messages.json Show resolved Hide resolved
Да, здесь ошибка, спасибо

Co-Authored-By: Dmitriy Ryajov <[email protected]>
Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @zlocate!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants